Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tileserver-gl/5.1.1 package update #39323

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Jan 11, 2025

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Jan 11, 2025
Copy link
Contributor Author

octo-sts bot commented Jan 11, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

Based on the error output, I'll analyze and provide a solution:

• Detected Error:

[git checkout] execute: env GIT_COMMITTER_DATE=@1736574739 git cherry-pick -x 93f72c1fe7671429f234c853e81f202e635522e9
fatal: bad object 93f72c1fe7671429f234c853e81f202e635522e9
[git checkout] failed to cherry-pick 93f72c1fe7671429f234c853e81f202e635522e9 from branch master

• Error Category: Version/Git

• Failure Point: Cherry-pick operation in git-checkout pipeline step

• Root Cause Analysis: The cherry-pick operation is failing because the specified commit hash (93f72c1fe7671429f234c853e81f202e635522e9) does not exist in the repository's master branch. This could be due to:

  1. The commit hash being incorrect
  2. The commit being rebased or removed from the master branch
  3. The repository history being modified

• Suggested Fix:

  1. Remove or update the cherry-pick section in the YAML:
  - uses: git-checkout
    with:
      repository: https://github.com/maptiler/tileserver-gl
      tag: v${{package.version}}
      expected-commit: f7be63a35ceefd14f8dbbfdf06920485f1f079dc
      destination: app
      # Either remove the cherry-picks section or update with correct commit
  1. If the security fix is still needed, find the correct commit hash from the master branch or incorporate the changes directly as a patch file.

• Explanation: The build is failing because it cannot find the specified commit to cherry-pick. By removing the invalid cherry-pick operation or updating it with the correct commit hash, the build should proceed successfully. If the security fix is still required, it should be applied through an alternative method such as a patch file.

• Additional Notes:

  • The commit appears to be related to a CVE fix (GHSA-3xgq-45jj-v275)
  • Consider creating a patch file containing the security fix instead of relying on cherry-pick
  • Verify the current status of the CVE fix in the upstream repository

• References:

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Jan 11, 2025
@Dentrax Dentrax self-assigned this Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR automated pr request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants